From 5513a9a1e91c1027d39ad41d0df304284c46442c Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=A9mie=20Astor?= <astor.jeremie@wanadoo.fr>
Date: Fri, 8 May 2020 12:09:15 +0200
Subject: [PATCH] :art: Improve check_lambda

---
 include/env/func.h |  2 +-
 include/parse.h    |  1 +
 src/lib/func.c     | 21 ++++++++-------------
 src/parse/check.c  |  2 +-
 4 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/include/env/func.h b/include/env/func.h
index 17df2035..5375b0a6 100644
--- a/include/env/func.h
+++ b/include/env/func.h
@@ -13,5 +13,5 @@ struct Func_ {
 
 ANEW ANN Func new_func(MemPool, const m_str, const Func_Def);
 ANN2(1,2) Symbol func_symbol(const Env, const m_str, const m_str, const m_str, const m_uint);
-ANN2(1,3,4) m_bool check_lambda(const Env, const Type, Exp_Lambda*, const Func_Def);
+ANN m_bool check_lambda(const Env, const Type, Exp_Lambda*);
 #endif
diff --git a/include/parse.h b/include/parse.h
index af616b36..992b1d37 100644
--- a/include/parse.h
+++ b/include/parse.h
@@ -77,6 +77,7 @@ static inline m_bool prefix##_cdef(const Env env, const Class_Def cdef) { \
   return scanx_cdef(env, env, cdef,                                       \
       (_exp_func)prefix##_class_def, (_exp_func)prefix##_union_def);      \
 }
+xxx_cdef_flag(scan0)
 xxx_cdef_flag(scan1)
 xxx_cdef_flag(scan2)
 xxx_cdef_flag(check)
diff --git a/src/lib/func.c b/src/lib/func.c
index c977bf6a..cd148023 100644
--- a/src/lib/func.c
+++ b/src/lib/func.c
@@ -165,27 +165,21 @@ ANN static m_bool _check_lambda(const Env env, Exp_Lambda *l, const Func_Def def
   return GW_OK;
 }
 
-ANN2(1,3,4) m_bool check_lambda(const Env env, const Type owner,
-    Exp_Lambda *l, const Func_Def def) {
+ANN m_bool check_lambda(const Env env, const Type t, Exp_Lambda *l) {
+  const Func_Def fdef = t->e->d.func->def;
   struct EnvSet es = { .env=env, .data=env, .func=(_exp_func)check_cdef,
     .scope=env->scope->depth, .flag=ae_flag_check };
-  if((l->owner = owner))
-    envset_push(&es, owner);
-  const m_bool ret = _check_lambda(env, l, def);
+  if((l->owner = t->e->owner_class))
+    envset_push(&es, l->owner);
+  const m_bool ret = _check_lambda(env, l, fdef);
   if(es.run)
-    envset_pop(&es, owner);
+    envset_pop(&es, l->owner);
   if(ret < 0)
     return GW_ERROR;
   exp_self(l)->info->type = l->def->base->func->value_ref->type;
   return GW_OK;
 }
 
-ANN static m_bool fptr_lambda(const Env env, struct FptrInfo *info) {
-  Exp_Lambda *l = &info->exp->d.exp_lambda;
-  const Type owner = info->rhs->value_ref->from->owner_class;
-  return check_lambda(env, owner, l, info->rhs->def);
-}
-
 ANN static m_bool fptr_do(const Env env, struct FptrInfo *info) {
   if(isa(info->exp->info->type, env->gwion->type[et_lambda]) < 0) {
     m_bool nonnull = GET_FLAG(info->exp->info->type, nonnull);
@@ -194,7 +188,8 @@ ANN static m_bool fptr_do(const Env env, struct FptrInfo *info) {
     info->exp->info->type = !nonnull ? t : type_nonnull(env, t);
     return GW_OK;
   }
-  return fptr_lambda(env, info);
+  Exp_Lambda *l = &info->exp->d.exp_lambda;
+  return check_lambda(env, actual_type(env->gwion, info->rhs->value_ref->type), l);
 }
 
 static OP_CHECK(opck_fptr_at) {
diff --git a/src/parse/check.c b/src/parse/check.c
index 3d9329f0..d8ba501e 100644
--- a/src/parse/check.c
+++ b/src/parse/check.c
@@ -389,7 +389,7 @@ ANN static m_bool func_match_inner(const Env env, const Exp e, const Type t,
     array_base(e->info->type) == array_base(t);
     if(!match) {
       if(e->info->type == env->gwion->type[et_lambda] && is_fptr(env->gwion, t)) {
-        const m_bool ret = check_lambda(env, t->e->owner_class, &e->d.exp_lambda, t->e->d.func->def);
+        const m_bool ret = check_lambda(env, t, &e->d.exp_lambda);
         exp_setvar(e, 1);
         return ret;
       }
-- 
2.43.0