:art: Use Shellcheck

diff --git a/Makefile b/Makefile
index 05417ad0381d0d1e9ee3403c0098aec545e97ad4..06945d36064c84f6f861a975e9c3a229b1e6b378 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -110,7 +110,7 @@ uninstall:
        rm ${DESTDIR}/${PREFIX}/bin/${PRG}
 
 test:
-       @bash help/test.sh ${test_dir}
+       @bash scripts/test.sh ${test_dir}
 
 include $(wildcard .d/*.d)
 include util/intl.mk

diff --git a/scripts/doc-config.sh b/scripts/doc-config.sh
index 6f197cec22dfdd3f8ac9936a6931ff98bdb1c29d..01067a63b787edfcf48b4418aee6715d303737ad 100644 (file)
--- a/scripts/doc-config.sh
+++ b/scripts/doc-config.sh
@@ -1,16 +1,17 @@
+#!/bin/bash
 title() {
-  TMP=$(head -n 1 $1)
+  TMP=$(head -n 1 "$1")
   sed "s/'/\'/" <<< "${TMP:2}"
 }
 
 list_dir() {
   [[ "$1" == */"assets" ]] && return
-  for a in $1/*
+  for a in "$1"/*
   do
     if [ -d "$a" ]
     then [[ "$a" == */"assets" ]] ||
-         echo "$2- '$(basename $a | sed 's/[0-9][0-9]_//' | sed 's/_/ /g' | sed 's/-/ /g')':"; list_dir "$a" "$2  "
-    else echo "$a" | grep "\.md$" >/dev/null  && echo "$2- '$(title $a)': ${a:5}"
+         echo "$2- '$(basename "$a" | sed 's/[0-9][0-9]_//' | sed 's/_/ /g' | sed 's/-/ /g')':"; list_dir "$a" "$2"
+    else echo "$a" | grep "\.md$" >/dev/null  && echo "$2- '$(title "$a")': ${a:5}"
     fi
   done
 }

diff --git a/tests/sh/plugin.sh b/tests/sh/plugin.sh
index 93616113d65c0ede1cbbeddde29c509d227233a4..561efb61e4cb11387b2a029014ed7306521e0716 100644 (file)
--- a/tests/sh/plugin.sh
+++ b/tests/sh/plugin.sh
@@ -38,7 +38,7 @@ rm "empty.so"
 BASE_DIR="$PWD"
 cd tests/import || exit
 for test_file in *.c
-do test_plugin "$(basename $test_file .c)"
+do test_plugin "$(basename "$test_file" .c)"
 done
 
 DRIVER="driver_test:arg" test_plugin driver